Re: [Intel-wired-lan] [PATCH iwl-next 06/12] idpf: merge singleq and splitq &net_device_ops

[Jacob Keller]

On 5/28/2024 6:48 AM, Alexander Lobakin wrote:
> It makes no sense to have a second &net_device_ops struct (800 bytes of
> rodata) with only one difference in .ndo_start_xmit, which can easily
> be just one `if`. This `if` is a drop in the ocean and you won't see
> any difference.
> Define unified idpf_xmit_start(). The preparation for sending is the
> same, just call either idpf_tx_splitq_frame() or idpf_tx_singleq_frame()
> depending on the active model to actually map and send the skb.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com>
> Signed-off-by: Alexander Lobakin <aleksander.loba...@intel.com>
> ---

Makes sense.

Reviewed-by: Jacob Keller <jacob.e.kel...@intel.com>