> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Karol > Kolacinski > Sent: Thursday, June 20, 2024 5:57 PM > To: [email protected] > Cc: Keller, Jacob E <[email protected]>; [email protected]; > Kolacinski, Karol <[email protected]>; Nguyen, Anthony L > <[email protected]>; Kitszel, Przemyslaw > <[email protected]> > Subject: [Intel-wired-lan] [PATCH v2 iwl-net 2/3] ice: Don't process extts if > PTP is disabled > > From: Jacob Keller <[email protected]> > > The ice_ptp_extts_event() function can race with ice_ptp_release() and result > in a NULL pointer dereference which leads to a kernel panic. > > Panic occurs because the ice_ptp_extts_event() function calls > ptp_clock_event() with a NULL pointer. The ice driver has already released > the PTP clock by the time the interrupt for the next external timestamp event > occurs. > > To fix this, modify the ice_ptp_extts_event() function to check the PTP state > and bail early if PTP is not ready. > > Fixes: 172db5f91d5f ("ice: add support for auxiliary input/output pins") > Reviewed-by: Przemek Kitszel <[email protected]> > Signed-off-by: Jacob Keller <[email protected]> > Signed-off-by: Karol Kolacinski <[email protected]> > --- > V1 -> V2: removed unnecessary hunk of code and adjusted commit message > > drivers/net/ethernet/intel/ice/ice_ptp.c | 4 ++++ > 1 file changed, 4 insertions(+) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
