> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Karol > Kolacinski > Sent: Thursday, June 20, 2024 5:57 PM > To: [email protected] > Cc: Keller, Jacob E <[email protected]>; [email protected]; > Kolacinski, Karol <[email protected]>; Nguyen, Anthony L > <[email protected]>; Kitszel, Przemyslaw > <[email protected]> > Subject: [Intel-wired-lan] [PATCH v2 iwl-net 3/3] ice: Reject pin requests > with unsupported flags > > From: Jacob Keller <[email protected]> > > The driver receives requests for configuring pins via the .enable callback of > the PTP clock object. These requests come into the driver with flags which > modify the requested behavior from userspace. Current implementation in ice > does not reject flags that it doesn't support. > This causes the driver to incorrectly apply requests with such flags as > PTP_PEROUT_DUTY_CYCLE, or any future flags added by the kernel which it is > not yet aware of. > > Fix this by properly validating flags in both ice_ptp_cfg_perout and > ice_ptp_cfg_extts. Ensure that we check by bit-wise negating supported flags > rather than just checking and rejecting known un-supported flags. > This is preferable, as it ensures better compatibility with future kernels. > > Fixes: 172db5f91d5f ("ice: add support for auxiliary input/output pins") > Reviewed-by: Przemek Kitszel <[email protected]> > Signed-off-by: Jacob Keller <[email protected]> > Signed-off-by: Karol Kolacinski <[email protected]> > --- > V1 -> V2: adjusted indentation and added NULL config pointer check > > drivers/net/ethernet/intel/ice/ice_ptp.c | 38 ++++++++++++++---------- > drivers/net/ethernet/intel/ice/ice_ptp.h | 1 + > 2 files changed, 23 insertions(+), 16 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
