On Wed, Jul 10, 2024 at 03:39:49PM +0300, Aleksandr Mishin wrote: > In ice_sched_add_root_node() and ice_sched_add_node() there are calls to > devm_kcalloc() in order to allocate memory for array of pointers to > 'ice_sched_node' structure. But incorrect types are used as sizeof() > arguments in these calls (structures instead of pointers) which leads to > over allocation of memory. > > Adjust over allocation of memory by correcting types in devm_kcalloc() > sizeof() arguments. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Reviewed-by: Przemek Kitszel <[email protected]> > Signed-off-by: Aleksandr Mishin <[email protected]> > --- > v4: > - Remove Suggested-by: Przemek Kitszel <[email protected]> > - Add Reviewed-by: Przemek Kitszel <[email protected]> > > (https://lore.kernel.org/all/[email protected]/) > v3: https://lore.kernel.org/all/[email protected]/ > - Update comment and use the correct entities as suggested by Przemek > v2: https://lore.kernel.org/all/[email protected]/ > - Update comment, remove 'Fixes' tag and change the tree from 'net' to > 'net-next' as suggested by Simon > (https://lore.kernel.org/all/[email protected]/) > v1: https://lore.kernel.org/all/[email protected]/
Thanks for your persistence, this version looks good to me. Reviewed-by: Simon Horman <[email protected]>
