> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Aleksandr Mishin > Sent: Wednesday, July 10, 2024 6:10 PM > To: Anirudh Venkataramanan <[email protected]> > Cc: [email protected]; [email protected]; > [email protected]; Kitszel, Przemyslaw > <[email protected]>; Eric Dumazet <[email protected]>; Nguyen, > Anthony L <[email protected]>; Aleksandr Mishin > <[email protected]>; [email protected]; Jakub Kicinski > <[email protected]>; Paolo Abeni <[email protected]>; David S. Miller > <[email protected]> > Subject: [Intel-wired-lan] [PATCH net-next v4] ice: Adjust over allocation of > memory in ice_sched_add_root_node() and ice_sched_add_node() > > In ice_sched_add_root_node() and ice_sched_add_node() there are calls to > devm_kcalloc() in order to allocate memory for array of pointers to > 'ice_sched_node' structure. But incorrect types are used as sizeof() > arguments in these calls (structures instead of pointers) which leads to over > allocation of memory. > > Adjust over allocation of memory by correcting types in devm_kcalloc() > sizeof() arguments. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Reviewed-by: Przemek Kitszel <[email protected]> > Signed-off-by: Aleksandr Mishin <[email protected]> > --- > v4: > - Remove Suggested-by: Przemek Kitszel <[email protected]> > - Add Reviewed-by: Przemek Kitszel <[email protected]> > > (https://lore.kernel.org/all/[email protected]/) > v3: https://lore.kernel.org/all/[email protected]/ > - Update comment and use the correct entities as suggested by Przemek > v2: https://lore.kernel.org/all/[email protected]/ > - Update comment, remove 'Fixes' tag and change the tree from 'net' to > 'net-next' as suggested by Simon > (https://lore.kernel.org/all/[email protected]/) > v1: https://lore.kernel.org/all/[email protected]/ > > drivers/net/ethernet/intel/ice/ice_sched.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
