> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Karol > Kolacinski > Sent: Monday, September 30, 2024 5:43 PM > To: [email protected] > Cc: [email protected]; Kolacinski, Karol <[email protected]>; > Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw > <[email protected]> > Subject: [Intel-wired-lan] [PATCH v12 iwl-next 1/7] ice: Don't check device > type when checking GNSS presence > > Don't check if the device type is E810T as non-E810T devices can support GNSS > too and PCA9575 check is enough to determine if GNSS is present or not. > > Rename ice_gnss_is_gps_present() to ice_gnss_is_module_present() because GNSS > module supports multiple GNSS providers, not only GPS. > > Move functions related to PCA9575 from ice_ptp_hw.c to ice_common.c to be > able to access them when PTP is disabled in the kernel, but GNSS is enabled. > > Remove logical AND with ICE_AQC_LINK_TOPO_NODE_TYPE_M in > ice_get_pca9575_handle(), which has no effect, and reorder device type checks > to check the device_id first, then set other variables. > > Signed-off-by: Karol Kolacinski <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_common.c | 90 ++++++++++++++++++++ > drivers/net/ethernet/intel/ice/ice_common.h | 2 + > drivers/net/ethernet/intel/ice/ice_gnss.c | 29 +++---- > drivers/net/ethernet/intel/ice/ice_gnss.h | 4 +- > drivers/net/ethernet/intel/ice/ice_lib.c | 2 +- > drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 93 --------------------- > drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 1 - > 7 files changed, 105 insertions(+), 116 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
