> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Karol > Kolacinski > Sent: Monday, September 30, 2024 5:43 PM > To: [email protected] > Cc: [email protected]; Kolacinski, Karol <[email protected]>; > Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw > <[email protected]> > Subject: [Intel-wired-lan] [PATCH v12 iwl-next 2/7] ice: Remove unncecessary > ice_is_e8xx() functions > > Remove unnecessary ice_is_e8xx() functions and PHY model. Instead, use MAC > type where applicable. > > Don't check device type in ice_ptp_maybe_trigger_tx_interrupt(), because in > reality it depends on the ready bitmap, which only E810 does not have. > > Call ice_ptp_cfg_phy_interrupt() unconditionally, because all further > function calls check the MAC type anyway and this allows simpler code in the > future with addition of the new MAC types. > > Reorder ICE_MAC_* cases in switches in ice_ptp* as in enum ice_mac_type. > > Signed-off-by: Karol Kolacinski <[email protected]> > --- > V9 -> V10: Fixed E825C MAC condition in ice_parse_1588_func_caps() > V8 -> V9: Fixed compilation issue after rebase > V7 -> V8: Added reordering of ICE_MAC_* cases in switches and explained the > rest > of previous changes in the commit description > > drivers/net/ethernet/intel/ice/ice.h | 5 - > drivers/net/ethernet/intel/ice/ice_common.c | 120 +---------------- > drivers/net/ethernet/intel/ice/ice_common.h | 5 - > drivers/net/ethernet/intel/ice/ice_ddp.c | 4 +- > drivers/net/ethernet/intel/ice/ice_ptp.c | 137 +++++++++---------- > drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 138 ++++++++++---------- > drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 20 +-- > drivers/net/ethernet/intel/ice/ice_type.h | 9 -- > 8 files changed, 155 insertions(+), 283 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
