On Thu, Dec 19, 2024 at 06:09:32PM -0800, Emil Tantilov wrote:
> Restore the call to idpf_vc_xn_shutdown() at the beginning of
> idpf_vc_core_deinit() provided the function is not called on remove.
> In the reset path the mailbox is destroyed, leading to all transactions
> timing out.
>
> Fixes: 09d0fb5cb30e ("idpf: deinit virtchnl transaction manager after vport
> and vectors")
> Reviewed-by: Larysa Zaremba <[email protected]>
> Signed-off-by: Emil Tantilov <[email protected]>
> ---
> Changelog:
> v2:
> - Assigned the current state of REMOVE_IN_PROG flag to a boolean
> variable, to be checked instead of reading the flag twice.
> - Updated the description to clarify the reason for the timeouts on
> reset is due to the mailbox being destroyed.
>
> v1:
> https://lore.kernel.org/intel-wired-lan/[email protected]/
>
> Testing hints:
> echo 1 > /sys/class/net/<netif>/device/reset
Thanks for the update,
Reviewed-by: Simon Horman <[email protected]>