> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Simon Horman > Sent: Monday, January 6, 2025 2:45 AM > To: Tantilov, Emil S <[email protected]> > Cc: [email protected]; [email protected]; Zaremba, Larysa > <[email protected]>; [email protected]; [email protected]; > Nguyen, Anthony L <[email protected]>; [email protected]; > [email protected]; [email protected]; [email protected]; Lobakin, > Aleksander <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] idpf: fix transaction > timeouts > on reset > > On Thu, Dec 19, 2024 at 06:09:32PM -0800, Emil Tantilov wrote: > > Restore the call to idpf_vc_xn_shutdown() at the beginning of > > idpf_vc_core_deinit() provided the function is not called on remove. > > In the reset path the mailbox is destroyed, leading to all transactions > > timing out. > > > > Fixes: 09d0fb5cb30e ("idpf: deinit virtchnl transaction manager after vport > and vectors") > > Reviewed-by: Larysa Zaremba <[email protected]> > > Signed-off-by: Emil Tantilov <[email protected]> > > --- > > Changelog: > > v2: > > - Assigned the current state of REMOVE_IN_PROG flag to a boolean > > variable, to be checked instead of reading the flag twice. > > - Updated the description to clarify the reason for the timeouts on > > reset is due to the mailbox being destroyed. > > > > v1: > > https://lore.kernel.org/intel-wired-lan/20241218014417.3786-1- > [email protected]/ > > > > Testing hints: > > echo 1 > /sys/class/net/<netif>/device/reset > > Thanks for the update, > > Reviewed-by: Simon Horman <[email protected]>
Tested-by: Krishneil Singh <[email protected]>
