> -----Original Message----- > From: Simon Horman <[email protected]> > Sent: Friday, February 7, 2025 11:04 AM > To: Nitka, Grzegorz <[email protected]> > Cc: [email protected]; [email protected]; Nguyen, > Anthony L <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Kolacinski, Karol > <[email protected]> > Subject: Re: [PATCH iwl-next v1 1/3] ice: Add sync delay for E825C > > On Thu, Feb 06, 2025 at 09:36:53AM +0100, Grzegorz Nitka wrote: > > From: Karol Kolacinski <[email protected]> > > > > Implement setting GLTSYN_SYNC_DLAY for E825C products. > > This is the execution delay compensation of SYNC command between > > PHC and PHY. > > Also, refactor the code by changing ice_ptp_init_phc_eth56g function > > name to ice_ptp_init_phc_e825, to be consistent with the naming pattern > > for other devices. > > Adding support for GLTSYN_SYNC_DLAY and the refactor seem > to be two distinct changes, albeit touching common code. > > I think it would be slightly better to split this into two patches. > Sure, will exclude this commit from the series and will submit it as separate patch. Thanks for your review and valuable feedback.
> > Reviewed-by: Przemek Kitszel <[email protected]> > > Signed-off-by: Karol Kolacinski <[email protected]> > > Signed-off-by: Grzegorz Nitka <[email protected]> > > ...
