> -----Original Message----- > From: Simon Horman <[email protected]> > Sent: Friday, February 7, 2025 11:06 AM > To: Nitka, Grzegorz <[email protected]> > Cc: [email protected]; [email protected]; Nguyen, > Anthony L <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Kolacinski, Karol > <[email protected]> > Subject: Re: [PATCH iwl-next v1 2/3] ice: Refactor E825C PHY registers info > struct > > On Fri, Feb 07, 2025 at 10:03:45AM +0000, Simon Horman wrote: > > On Thu, Feb 06, 2025 at 09:36:54AM +0100, Grzegorz Nitka wrote: > > > From: Karol Kolacinski <[email protected]> > > > > > > Simplify ice_phy_reg_info_eth56g struct definition to include base > > > address for the very first quad. Use base address info and 'step' > > > value to determine address for specific PHY quad. > > > > > > Reviewed-by: Przemek Kitszel <[email protected]> > > > Signed-off-by: Karol Kolacinski <[email protected]> > > > Signed-off-by: Grzegorz Nitka <[email protected]> > > > > Reviewed-by: Simon Horman <[email protected]> > > Sorry, I failed to notice that the kdoc for ice_phy_reg_info_eth56g > needs to be updated to document base_addr instead of base.
Good catch! Thanks! To be fixed in v2.
