> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Simon Horman > Sent: Thursday, February 20, 2025 3:56 PM > To: Zaremba, Larysa <[email protected]> > Cc: Nguyen, Anthony L <[email protected]>; intel-wired- > [email protected]; Kitszel, Przemyslaw <[email protected]>; > Andrew Lunn <[email protected]>; David S. Miller > <[email protected]>; Eric Dumazet <[email protected]>; Jakub > Kicinski <[email protected]>; Paolo Abeni <[email protected]>; > [email protected]; [email protected]; Michal Swiatkowski > <[email protected]>; Pacuszka, MateuszX > <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 1/6] ice: fix check for > existing > switch rule > > On Fri, Feb 14, 2025 at 09:50:35AM +0100, Larysa Zaremba wrote: > > From: Mateusz Pacuszka <[email protected]> > > > > In case the rule already exists and another VSI wants to subscribe to > > it new VSI list is being created and both VSIs are moved to it. > > Currently, the check for already existing VSI with the same rule is > > done based on fdw_id.hw_vsi_id, which applies only to LOOKUP_RX flag. > > Change it to vsi_handle. This is software VSI ID, but it can be > > applied here, because vsi_map itself is also based on it. > > > > Additionally change return status in case the VSI already exists in > > the VSI map to "Already exists". Such case should be handled by the caller. > > FWIIW, I might have made this two patches, but I don't feel particularly > strongly about it. > > > > > Signed-off-by: Mateusz Pacuszka <[email protected]> > > Reviewed-by: Przemek Kitszel <[email protected]> > > Reviewed-by: Michal Swiatkowski <[email protected]> > > Signed-off-by: Larysa Zaremba <[email protected]> > > Reviewed-by: Simon Horman <[email protected]>
Tested-by: Rafal Romanowski <[email protected]>
