On Wed, Aug 13, 2025 at 12:45:17PM +0200, Przemek Kitszel wrote:
> From: Lukasz Czapnik <[email protected]>
>
> The ITR index (itr_idx) is only 2 bits wide. When constructing the
> register value for QINT_RQCTL, all fields are ORed together. Without
> masking, higher bits from itr_idx may overwrite adjacent fields in the
> register.
>
> Apply I40E_QINT_RQCTL_ITR_INDX_MASK to ensure only the intended bits are
> set.
I'm all for using FIELD_PREP.
But can this actually occur?
If not, it feels more like a clean-up.
Which could be more universally applied.
And targeted at net-next (without a Fixes tag).
>
> Fixes: 5c3c48ac6bf5 ("i40e: implement virtual device interface")
> Cc: [email protected]
> Signed-off-by: Lukasz Czapnik <[email protected]>
> Reviewed-by: Aleksandr Loktionov <[email protected]>
> Signed-off-by: Przemek Kitszel <[email protected]>
My question about the target-tree aside, this looks good to me.
Reviewed-by: Simon Horman <[email protected]>
