On 8/26/25 18:34, Simon Horman wrote:
On Wed, Aug 13, 2025 at 12:45:17PM +0200, Przemek Kitszel wrote:
From: Lukasz Czapnik <[email protected]>
The ITR index (itr_idx) is only 2 bits wide. When constructing the
register value for QINT_RQCTL, all fields are ORed together. Without
masking, higher bits from itr_idx may overwrite adjacent fields in the
register.
Apply I40E_QINT_RQCTL_ITR_INDX_MASK to ensure only the intended bits are
set.
I'm all for using FIELD_PREP.
But can this actually occur?
If not, it feels more like a clean-up.
I don't see any other place that we validate VF-provided ::rxitr_idx and
::txitr_idx of struct virtchnl_vector_map. So it's up to rogue VF.
With that, I would like to keep this as a fix.
Which could be more universally applied.
this is also true, we typically apply such conversions when doing other
work that is related (so this time it kind of triggers :))
And targeted at net-next (without a Fixes tag).
Fixes: 5c3c48ac6bf5 ("i40e: implement virtual device interface")
Cc: [email protected]
Signed-off-by: Lukasz Czapnik <[email protected]>
Reviewed-by: Aleksandr Loktionov <[email protected]>
Signed-off-by: Przemek Kitszel <[email protected]>
My question about the target-tree aside, this looks good to me.
Reviewed-by: Simon Horman <[email protected]>
thank you for looking into this series
