On Thu, Nov 20, 2025 at 12:20:43PM -0800, Jacob Keller wrote: > The ice_qp_reset_stats function resets the stats for all rings on a VSI. It > currently behaves differently for Tx and Rx rings. For Rx rings, it only > clears the rx_stats which do not include the pkt and byte counts. For Tx > rings and XDP rings, it clears only the pkt and byte counts. > > We could add extra memset calls to cover both the stats and relevant > tx/rx stats fields. Instead, lets convert stats into a struct_group which > contains both the pkts and bytes fields as well as the Tx or Rx stats, and > remove the ice_q_stats structure entirely. > > The only remaining user of ice_q_stats is the ice_q_stats_len function in > ice_ethtool.c, which just counts the number of fields. Replace this with a > simple multiplication by 2. I find this to be simpler to reason about than > relying on knowing the layout of the ice_q_stats structure. > > Now that the stats field of the ice_ring_stats covers all of the statistic > values, the ice_qp_reset_stats function will properly zero out all of the > fields. > > Reviewed-by: Aleksandr Loktionov <[email protected]> > Signed-off-by: Jacob Keller <[email protected]>
I agree this is both more consistent and cleaner. I do feel there might be a yet cleaner way to handle things in place of multiplication by 2. But I can't think of such a way at this time. Reviewed-by: Simon Horman <[email protected]>
