> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Jacob > Keller > Sent: 21 November 2025 01:51 > To: Loktionov, Aleksandr <[email protected]>; Lobakin, Aleksander > <[email protected]>; Nguyen, Anthony L > <[email protected]>; Kitszel, Przemyslaw > <[email protected]> > Cc: Simon Horman <[email protected]>; [email protected]; > [email protected]; Keller, Jacob E <[email protected]>; > Loktionov, Aleksandr <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next v4 3/6] ice: remove ice_q_stats > struct and use struct_group > > The ice_qp_reset_stats function resets the stats for all rings on a VSI. It > currently behaves differently for Tx and Rx rings. For Rx rings, it only > clears the rx_stats which do not include the pkt and byte counts. For Tx > rings and XDP rings, it clears only the pkt and byte counts. > > We could add extra memset calls to cover both the stats and relevant tx/rx > stats fields. Instead, lets convert stats into a struct_group which contains > both the pkts and bytes fields as well as the Tx or Rx stats, and remove the > ice_q_stats structure entirely. > > The only remaining user of ice_q_stats is the ice_q_stats_len function in > ice_ethtool.c, which just counts the number of fields. Replace this with a > simple multiplication by 2. I find this to be simpler to reason about than > relying on knowing the layout of the ice_q_stats structure. > > Now that the stats field of the ice_ring_stats covers all of the statistic > values, the ice_qp_reset_stats function will properly zero out all of the > fields. > > Reviewed-by: Aleksandr Loktionov <[email protected]> > Signed-off-by: Jacob Keller <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_txrx.h | 18 ++++++++---------- > drivers/net/ethernet/intel/ice/ice_base.c | 4 ++-- > drivers/net/ethernet/intel/ice/ice_ethtool.c | 4 ++-- > drivers/net/ethernet/intel/ice/ice_lib.c | 7 ++++--- > 4 files changed, 16 insertions(+), 17 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
