> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Larysa Zaremba
> Sent: Monday, November 17, 2025 5:49 AM
> To: [email protected]; Nguyen, Anthony L
> <[email protected]>
> Cc: Lobakin, Aleksander <[email protected]>; Samudrala, Sridhar
> <[email protected]>; Singhai, Anjali <[email protected]>;
> Michal Swiatkowski <[email protected]>; Zaremba, Larysa
> <[email protected]>; Fijalkowski, Maciej
> <[email protected]>; Tantilov, Emil S <[email protected]>;
> Chittim, Madhu <[email protected]>; Hay, Joshua A
> <[email protected]>; Keller, Jacob E <[email protected]>;
> Shanmugam, Jayaprakash <[email protected]>;
> Wochtman, Natalia <[email protected]>; Jiri Pirko
> <[email protected]>; David S. Miller <[email protected]>; Eric Dumazet
> <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni
> <[email protected]>; Simon Horman <[email protected]>; Jonathan
> Corbet <[email protected]>; Richard Cochran <[email protected]>;
> Kitszel, Przemyslaw <[email protected]>; Andrew Lunn
> <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]
> Subject: [Intel-wired-lan] [PATCH iwl-next v5 10/15] idpf: make mbx_task
> queueing and cancelling more consistent
> 
> As a consequence of refactoring idpf code to use libeth APIs,
> idpf_vc_xn_shutdown was merged with and replaced by
> idpf_deinit_dflt_mbx.
> This does not affect the Tx path, as it checked for a presence of an xn 
> manager
> anyway. Rx processing is handled by the mbx_task that is not always cancelled
> before calling the new consolidated mailbox deinit function.
> Moreover, in the reset path idpf_intr_rel() reschedules it after the deinit is
> done. This leads to mbx_task referencing the freed mailbox and causing
> KASAN warnings.
> 
> To remedy this, in the init path, do the first queueing of mbx_task in
> idpf_init_dflt_mbx(), in deinit and reset, always cancel the task in
> idpf_deinit_dflt_mbx() and in every flow first call idpf_mb_intr_rel_irq().
> 
> Reviewed-by: Emil Tantilov <[email protected]>
> Reviewed-by: Michal Kubiak <[email protected]>
> Signed-off-by: Larysa Zaremba <[email protected]>
> ---
> 2.47.0

Tested-by: Samuel Salin <[email protected]>

Reply via email to