> -----Original Message-----
> From: Loktionov, Aleksandr <[email protected]>
> Sent: Thursday, May 28, 2026 2:24 PM
> To: Nitka, Grzegorz <[email protected]>; [email protected]
> Cc: Vecera, Ivan <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected]; Kitszel,
> Przemyslaw <[email protected]>; [email protected];
> [email protected]; [email protected]; Kubalewski,
> Arkadiusz <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; Nguyen, Anthony L
> <[email protected]>; [email protected]; [email protected]
> Subject: RE: [Intel-wired-lan] [PATCH v11 net-next 6/8] ice: implement CPI
> support for E825C
>
>
>
> > -----Original Message-----
> > From: Intel-wired-lan <[email protected]> On Behalf
> > Of Grzegorz Nitka
> > Sent: Tuesday, May 26, 2026 11:34 AM
> > To: [email protected]
> > Cc: Vecera, Ivan <[email protected]>; [email protected];
> > [email protected]; [email protected]; [email protected]; Kitszel,
> > Przemyslaw <[email protected]>; [email protected];
> > [email protected]; [email protected]; Kubalewski,
> > Arkadiusz <[email protected]>; [email protected];
> > [email protected]; [email protected];
> > [email protected]; Nguyen, Anthony L
> > <[email protected]>; [email protected];
> [email protected]
> > Subject: [Intel-wired-lan] [PATCH v11 net-next 6/8] ice: implement CPI
> > support for E825C
> >
> > Add full CPI (Converged PHY Interface) command handling required for
> > E825C devices. The CPI interface allows the driver to interact with
> > PHY-side control logic through the LM/PHY command registers, including
> > enabling/disabling/selection of PHY reference clock.
> >
> > This patch introduces:
> > - a new CPI subsystem (ice_cpi.c / ice_cpi.h) implementing the CPI
> > request/acknowledge state machine, including REQ/ACK protocol,
> > command execution, and response handling
> > - helper functions for reading/writing PHY registers over Sideband
> > Queue
> > - CPI command execution API (ice_cpi_exec) and a helper for enabling
> > or
> > disabling Tx reference clocks (CPI 0xF1 opcode 'Config PHY
> > clocking')
> > - assurance of CPI transaction serialization into the CPI core.
> > CPI REQ/ACK is a multi-step handshake and must be executed
> > atomically per PHY. Centralize the lock in ice_cpi_exec() and
> > use adapter-scoped per-PHY mutexes, which match the hardware
> > sharing
> > model across PFs.
> > - addition of the non-posted write opcode (wr_np) to SBQ
> > - Makefile integration to build CPI support together with the PTP
> > stack
> >
> > This provides the infrastructure necessary to support PHY-side
> > configuration flows on E825C and is required for advanced link control
> > and Tx reference clock management.
> >
> > Reviewed-by: Arkadiusz Kubalewski <[email protected]>
> > Signed-off-by: Grzegorz Nitka <[email protected]>
> > ---
> > drivers/net/ethernet/intel/ice/Makefile | 2 +-
> > drivers/net/ethernet/intel/ice/ice_adapter.c | 4 +
> > drivers/net/ethernet/intel/ice/ice_adapter.h | 7 +
> > drivers/net/ethernet/intel/ice/ice_cpi.c | 362
> > +++++++++++++++++++
> > drivers/net/ethernet/intel/ice/ice_cpi.h | 58 +++
> > drivers/net/ethernet/intel/ice/ice_sbq_cmd.h | 5 +-
> > drivers/net/ethernet/intel/ice/ice_type.h | 2 +
> > 7 files changed, 437 insertions(+), 3 deletions(-) create mode
> > 100644 drivers/net/ethernet/intel/ice/ice_cpi.c
> > create mode 100644 drivers/net/ethernet/intel/ice/ice_cpi.h
> >
> > diff --git a/drivers/net/ethernet/intel/ice/Makefile
> > b/drivers/net/ethernet/intel/ice/Makefile
> > index 5b2c666496e7..38db476ab2ec 100644
> > --- a/drivers/net/ethernet/intel/ice/Makefile
> > +++ b/drivers/net/ethernet/intel/ice/Makefile
> > @@ -54,7 +54,7 @@ ice-$(CONFIG_PCI_IOV) += \
> > ice_vf_mbx.o \
> > ice_vf_vsi_vlan_ops.o \
> > ice_vf_lib.o
>
> ...
>
> > +/**
> > + * ice_cpi_ena_dis_clk_ref - enables/disables Tx reference clock on
> > +port
> > + * @hw: pointer to the HW struct
> > + * @phy: phy index of port for which Tx reference clock is
> > +enabled/disabled
> > + * @clk: Tx reference clock to enable or disable
> > + * @enable: bool value to enable or disable Tx reference clock
> > + *
> > + * This function executes CPI request to enable or disable specific
> > + * Tx reference clock on given PHY.
> > + *
> > + * Return: 0 on success, negative error code on failure.
> > + */
> > +int ice_cpi_ena_dis_clk_ref(struct ice_hw *hw, u8 phy,
> Parameter named "port" in .h but "phy" in .c.
>
> Everything else looks fine for me.
> Reviewed-by: Aleksandr Loktionov <[email protected]>
>
V12 was needed anyway. Fixed it there.
Thanks!
>
> > + enum ice_e825c_ref_clk clk, bool enable) {
> > + u16 val;
> > +
> > + val = FIELD_PREP(CPI_OPCODE_PHY_CLK_PHY_SEL_M, phy) |
> > + FIELD_PREP(CPI_OPCODE_PHY_CLK_REF_CTRL_M,
> > + enable ? CPI_OPCODE_PHY_CLK_ENABLE :
> > + CPI_OPCODE_PHY_CLK_DISABLE) |
> > + FIELD_PREP(CPI_OPCODE_PHY_CLK_REF_SEL_M, clk);
> > +
> > + return ice_cpi_set_cmd(hw, CPI_OPCODE_PHY_CLK, phy, 0, val); }
> > +
> > diff --git a/drivers/net/ethernet/intel/ice/ice_cpi.h
> > b/drivers/net/ethernet/intel/ice/ice_cpi.h
> > new file mode 100644
> > index 000000000000..f73329237a7f
> > --- /dev/null
> > +++ b/drivers/net/ethernet/intel/ice/ice_cpi.h
> > @@ -0,0 +1,58 @@
>
> ...
>
> > /* Port hardware description */
> > struct ice_hw {
> > u8 __iomem *hw_addr;
> > --
> > 2.39.3
