Summary: Ignore.

[Severity: Medium]

This guard only checks the VSI type.

yes, this is a fix for a scenario reachable w/o memory failures
added with hope that bots will complain less on other patches

Can pf->vsi_stats[vsi->idx] also be
NULL here for a PF, VF or other non-channel VSI?
> [...]

TLDR: preexising issue for low memory conditions


A later patch in this series, "ice: rebuild ring stats arrays instead of
reallocating them in place", appears to fix this

Then please simply ignore the comment now.
Anyway, patch 1 has fixes tag for newer commit than the last.

side comment:
This was (a screenful...) report to suggest minor change in a very small
patch, normally I would do that, but with our current "new world" it
would simply mean delaying me by 3+ days.

> Sashiko AI review ยท https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260925132636.123300-1-przemyslaw.kitszel%40intel.com

Reply via email to