On 9/29/26 4:04 PM, [email protected] wrote:
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Summary: Ignore.
Low priority / nit picks for your consideration:
- [Low] The commit message understates what the change does and the patch
has no Fixes: tag.
does not matter, it will be pulled as dependency by @stable maintainers
BTW, I have no idea if we should add Fixes tag for "smaller half" of the
fix if it belongs in the same series (and does something a tad better
than before).
If that would be a preference, the fixes tag is the same as for last
patch (with 3 more patches not carrying that exact tag)
Pre-existing issues:
- [Critical] Heap out-of-bounds write in ice_vsi_alloc_ring_stats()
(drivers/net/ethernet/intel/ice/ice_lib.c).
- [Medium] The shrink loops in ice_vsi_realloc_stat_arrays()
(drivers/net/ethernet/intel/ice/ice_lib.c) still use…
pre-exisiting: for another time, and must compete with other driver
hardening ideas in our backlog
critical one has even a note:
The last patch in the series, "ice: size ring stats arrays from the
final queue count", fixes this
> Sashiko AI review ·
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260925132636.123300-1-przemyslaw.kitszel%40intel.com
