> -----Original Message----- > From: Jacob Keller <[email protected]> > Sent: Friday, September 25, 2026 4:57 PM > To: Intel Wired LAN <[email protected]>; Machnikowski, Maciej > <[email protected]>; Keller, Jacob E <[email protected]>; > Korba, Przemyslaw <[email protected]>; Nguyen, Anthony L > <[email protected]>; Nitka, Grzegorz <[email protected]>; > Kubalewski, Arkadiusz <[email protected]> > Cc: Keller, Jacob E <[email protected]>; Loktionov, Aleksandr > <[email protected]>; Kubalewski, Arkadiusz > <[email protected]>; Korba, Przemyslaw > <[email protected]>; Machnikowski, Maciej > <[email protected]> > Subject: [PATCH iwl-net v3 07/15] ice: E822: cancel offset verification work > during reset preparation > > From: Karol Kolacinski <[email protected]> > > The offset verification work task for E822 is executed after a PHY restart to > complete vernier calibration. In the event that either Tx or Rx calibration > hasn't finished, it may still be executing when a reset occurs. > > A single PF reset does not trigger a PHY restart, but larger resets (CORE, > GLOBAL, EMP) will initiate a PHY restart. > > The ice_ptp_wait_for_offsets() function does check if the driver is > resetting, and will reschedule itself. However, it is possible that a given > execution is already past this check. The function may then fail to access > the sideband queue. It treats failures as a reason to re-schedule and check > again later. This re-schedule will then see the updated reset state via > ice_is_reset_in_progress() and will keep re-scheduling until the reset > finishes. > > The larger resets will restart the PHY, canceling any outstanding vernier > calibration and forcing a restart. Preemptively cancel the task for non-PF > resets to avoid doing unnecessary checks while resetting. The task is not > canceled for a PF reset, otherwise nothing would restart the task to finish > vernier calibration after the reset. > > Fixes: 95af1f1c4c9f ("ice: reschedule ice_ptp_wait_for_offset_valid during > reset") > Signed-off-by: Karol Kolacinski <[email protected]> > Reviewed-by: Aleksandr Loktionov <[email protected]> > Signed-off-by: Arkadiusz Kubalewski <[email protected]> > Signed-off-by: Przemyslaw Korba <[email protected]> > Reviewed-by: Maciek Machnikowski <[email protected]> > Signed-off-by: Jacob Keller <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_ptp.c | 3 +++ > 1 file changed, 3 insertions(+)
Tested-by: Alexander Nowlin <[email protected]>
