On Fri, 25 Jun 2004, Stefan Esser wrote: > am I correct in assuming that input_filters are allowed todo whatever > they want with the value? > > I am asking, because this is not properly documented and atleast the > mbstring extension violates this. > > First of all it feeds input_filter a value pointer that is NOT allocated > with emalloc and secondly it free()s the wrong address in case the > input_filter has erealloc()ated value (but most probably the erealloc() > will already crash because the memory is allocated with malloc() instead > of emalloc())
Yeah, this should probably be more strictly defined. I think I am probably the only one using this and my filters never grow the string so I don't have these problems. > And the second question is: Is there any argument against backporting > the input_filter functionality to PHP4? I do not know what the plans > are, but I doubt PHP4 will die out with the release of PHP5 and so the > question is if we partly backport new functionality for PHP4 from PHP5 > into PHP 4.4 No real porting necessary. This area of the code is identical in PHP4 and PHP5, so it would just be a matter of adding the hook. I am using this extensively with PHP4. -Rasmus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
