Hey Dan, Gabriel, On Wed, Jun 17, 2020 at 12:17 PM Dan Ackroyd <dan...@basereality.com> wrote:
> On Wed, 17 Jun 2020 at 03:00, Gabriel Caruso <carusogabrie...@gmail.com> > wrote: > > > > so changing it to `void` and > > just invoke these methods sounds reasonable to me. > > What's the benefit of doing the change? > > There will almost certainly be some code somewhere that would be > broken by changing it, so it needs some benefit for doing it. > > I strongly suspect just updating the documentation to be correct, and > then leaving the code behaving as it has been for the past decade or > so, would be a better strategy. > Perhaps this is a good chance to fix the quirks around the `false` type, as well as introducing the `true` type (and using it for these specific functions)? See https://3v4l.org/ZnWmc/rfc#output See https://3v4l.org/MqsvC/rfc#output Marco Pivetta http://twitter.com/Ocramius http://ocramius.github.com/