> > https://wiki.php.net/rfc/random_extension_improvement > > Hi Internals. > > Currently, the renaming of Randomizer::shuffleString() to > Randomizer::shuffleBytes() seems acceptable. > > I forgot to note the change regarding arguments when I submitted this RFC. > With this change, the argument was supposed to be changed from `string > $string` to `string $bytes`. > > - https://github.com/php/php-src/pull/8094#discussion_r916630626
For reference, first was https://github.com/php/php-src/pull/8094/commits/32e83a71eae67fdd822fd12ded5a8c054024a4da#r916058794 > Is this change acceptable? Or should I keep `string $string`? -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
