On 8/11/23 03:06, Saki Takamachi wrote:
I have added as much of the rationale for the changes as I can think of to the
RFC. I would be happy if you could see it again.
Thanks for the detailed RFC and the PR.
I reviewed the RFC and the PR. I would vote in favour of this change.
I look forward to seeing a PR for the manual which will better explain
the limitations of decimal rounding of a binary floating point number.
The current manual entry for round() makes it sound as if it will
magically always work.
I think, most often, round() is done on the result of some
calculation, not on decimal literals. The previous implementation
seems to prioritize rounding of decimal literals over correct rounding
of the actual value.
-- Tim Starling
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php
