The patch doesn't just address realpath though.  We have a number of other
redundant/non-essential syscalls in the streams code, for example.  And
the realpath cache is still heavier than not worrying about the full path
at all.

I do agree that however people get this patch, they need to understand
that they are not running standard PHP and it is likely to break many
things.  At the same time, having it in CVS and maintainable by others and
having a single known version of this would help the people who use it and
the people who want to tweak their extensions to support it.

Perhaps we need a central php.net hosted and CVS-backed place for
unsupported patches and nasty hacks like this?  Useful ideas that are
applicable to a wider audience do often grow out of some of these crazy
hacks.

-Rasmus

On Tue, 14 Sep 2004, Andi Gutmans wrote:

> Hey Derick and all,
>
> As I mentioned in the past, I think solving it in a completely compatible
> manner is the best way to go.
> I sent out the realpath() cache patch which addresses the most problematic
> file system issues (and if there are any other things we could probably
> address too).
> I think there's a big advantage in having something which is completely
> compatible because we could enable it by default and all PHP users would
> benefit from it.
> I volunteer to put some gas on getting this patch production ready. Maybe I
> can send a new version in a couple of days and discuss what else it is missing?
>
> Andi
>
> At 02:10 PM 9/14/2004 +0200, Derick Rethans wrote:
> >Hei,
> >
> >This is Rasmus' patch including a configure option
> >"--disable-path-normalization" to enable this patch. By default this
> >option is of course turned off.
> >
> >I am planning to commit this patch after 4.3.9 is released too, in case
> >there are no good objections.
> >
> >Derick
> >
> >--
> >Derick Rethans
> >http://derickrethans.nl | http://ez.no | http://xdebug.org
> >--
> >PHP Internals - PHP Runtime Development Mailing List
> >To unsubscribe, visit: http://www.php.net/unsub.php
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to