Hi, On Fri, Jul 19, 2024 at 6:42 PM Gina P. Banyard <intern...@gpb.moe> wrote:
> Hello internals, > > I have opened the vote for the mega deprecation RFC: > https://wiki.php.net/rfc/deprecations_php_8_4 > > Reminder, each vote must be submitted individually. > > > Just wanted to send some reasoning of my no votes. I voted no on those output handlers as there might be potentially better solutions. The whole output stuff needs a closer look so I think we should wait on this until the review is done. Otherwise I also voted no for the mysqli_kill and mysqli_refresh functions as I feel that it's not a big deal to keep them (zero maintenance basically) and there will be likely users to use them. I think it would make sense to not add them but if there are already there I don't see a point to remove them. I think we should also keep file_put_contents array argument as it might actually be used with iovec in the future which could be a significant optimization - need to check details if that would work but if it does, it could be a pretty good optimization. The CSV one is also a bit weird because the default is non empty parameter so I'm not sure what this actually brings except some inconsistency. People that explicitly set it, do that probably for some reason. I would really prefer not to try to change this functionality as the BC breaks will cause more issues. All my other no are mainly about the BC concerns that I have. Regards Jakub
