Hi Jakub! On 22.07.2024 at 12:59, Jakub Zelenka wrote:
> On Fri, Jul 19, 2024 at 6:42 PM Gina P. Banyard <intern...@gpb.moe> wrote: > >> I have opened the vote for the mega deprecation RFC: >> https://wiki.php.net/rfc/deprecations_php_8_4 > > Just wanted to send some reasoning of my no votes. > > The CSV one is also a bit weird because the default is non empty parameter > so I'm not sure what this actually brings except some inconsistency. People > that explicitly set it, do that probably for some reason. I would really > prefer not to try to change this functionality as the BC breaks will cause > more issues. The default "\\" likely causes more harm than good for almost anybody. It basically enables a proprietary extension to CSV (something like DSV), but there are a couple of issues where it is totally unclear what should happen, and there still might be unresolved (because unresolvable) tickets lying around about that. I do have to agree, though, that this deprecation is somewhat unfortunate, since an empty string is only accepted as of PHP 7.4.0, so there is likely some code around which passes e.g. "\0" which also disables the proprietary extension if there are no NUL bytes in the CSV file (or to be written to a CSV file). For that reason I didn't vote on that deprecation, although I would not like to keep that proprietary extension forever. Cheers, Christoph
