On Thu, Dec 26, 2024, at 6:25 AM, Jakub Zelenka wrote: >> Point of order: The recently adopted 3rd party code policy does not apply to >> C tooling. It mentions "PHP Tooling", which is defined as "PHP code run by >> PHP.net". The website, docs tooling, etc. It has no bearing on what C >> libraries or toolchains can or should be used in php-src itself. (Whether >> that's unit testing, url parsers, HTML parsers, threading libraries, etc.) >> > > Ah ok, thanks for the clarification. This part (Definitions -> > Librarires) is slightly confusing in this regard though: > >> Refers to existing third party code packages or tools, either C extensions >> or PHP code, maintained by someone other than the PHP Internals team. > > Specifically that C extensions part made it sound like it also applies > to C code. But after reading the introduction, it's probably more as > you say, and it applies only to PHP code. > > Cheers > > Jakub
Ah, I can see how that could be interpreted that way, but that wasn't the intent. "C extensions" in this case means things like the MongoDB PECL extension, or Redis PECL extension. It's saying that if we wanted to start using Redis in the website somewhere (I dunno why, this is hypothetical), and that means using the Redis C PECL extension, that's allowed. --Larry Garfield
