Hi Antony, The changes to formatted_print.c caught my eye because I was going to inquire about/resubmit a patch from August to add new features the the *printf() functions... :-) I see you've added g/G (and E). In appenddouble, however, I noticed that the F specifier is missing. Nothing to me personally, just wondering about BC for users. I haven't tried anything yet, so maybe locale decimal point/not is handled differently now. Regardless, F will be ignored, though it's still present in php_formatted_print().
If you want to see the patch I made in the summer, see http://news.php.net/php.internals/25276 and http://realplain.com/php/printf_additions.diff I never got around to creating tests for the new features, and also thought I should [maybe] make some small changes in how I did the code. Of course now I'll need to reimplement the appenddouble changes anyway, to accommodate the new code. I guess I'll go ahead and redo it soon. Any comments about the additions/patch from you or anyone else? Marcus said they sounded good before I made the patch, but I didn't hear any more. :-/ Thanks, Matt ----- Original Message ----- From: "Antony Dovgal" Sent: Wednesday, December 06, 2006 > tony2001 Wed Dec 6 09:50:28 2006 UTC > > Modified files: > /ZendEngine2 zend.c zend_strtod.c zend_strtod.h > /php-src/ext/standard formatted_print.c > /php-src/ext/standard/tests/serialize 003.phpt > /php-src/ext/standard/tests/strings sprintf_f.phpt > /php-src/main snprintf.c snprintf.h spprintf.c > Log: > use BSD licensed implementation of double-to-string utilities instead of LGPL one > this patch also fixes thread safety issues in zend_strtod() > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
