On Jun 19, 2008, at 8:26 AM, Steph Fox wrote:
I can add this to PHPT - it uses a timeout based on reading the
open proc.
That's what the current run-tests does too. The problem is it isn't
reliable cross-platform - we don't have any control over the select
() function used by stream_select() except under Windows, where it
doesn't work (I'm looking into that but can't see why).
This doesn't help you yet, but that's a moot point in PHPT as it uses
COM under Windows as proc_* functions and the various stream
functions are less than reliable.
So what was wrong with the simple skipif and env var approach
again? If you're going to mark a test to get run-tests to respond
to it, it doesn't make a lot of difference whether you mark that
test by its name or with a skipif line. The only difference is an
untidy CVS directory.
There's nothing wrong with that approach. I'm trying to find
something that addresses the problem (i.e., "how can I not run tests
that are going to take a long time to run?"), while providing enough
flexibility to answer other problems (i.e., "how can I skip X tests
that I don't care about?").
If there's a way to address the problem without making it so
specific, I'm all for it.
I think the naming thing would be a better idea for something
that's just starting out. It's a less good idea for a test suite
that already exists IMHO.
Agreed. If we were to go this route, I'd actually consider adding a
run-tests.ini or some such that allows you to configure things like
excluded file patterns.
-T
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
