Hi Bob, I added a note that this API may be changed. I'm agree to go through regular voting process and change the syntax in the future. Right now I can't delay it, because this patch interferes with the other things we are doing and we just can't measure the real impact of the new optimizations.
BTW: now phpng makes 50% speedup on wordpress :) Thanks. Dmitry. On Sat, Jul 12, 2014 at 3:07 AM, Bob Weinand <bobw...@hotmail.com> wrote: > Hey Dmitry, > > I wonder why you pushed that before having any vote on the > https://wiki.php.net/rfc/fast_zpp RFC? > Please revert this until we've voted there. > > Thank you, > Bob > > Am 11.7.2014 um 18:54 schrieb Pierre Joye <pierre....@gmail.com>: > > hi Dmitry, > > > > And now I wonder why you even bother to propose it if you are going to > > push it anyway with phpng. This is not really a good way to push > > things, and as phpng is getting bigger and bigger nobody has a clue > > about what has been done and a vote will only be biased to begin with, > > based only on given performance results. It can't end well. > > > > Cheers, > > > > On Fri, Jul 11, 2014 at 2:32 PM, Dmitry Stogov <dmi...@php.net> wrote: > >> Commit: 27f38798a1963de1c60aae4ef8a3675138255574 > >> Author: Dmitry Stogov <dmi...@zend.com> Fri, 11 Jul 2014 > 16:32:20 +0400 > >> Parents: 8f229b285527a403d46be047546384032a0f6bb3 > >> Branches: phpng > >> > >> Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=27f38798a1963de1c60aae4ef8a3675138255574 > >> > >> Log: > >> Fast parameter parsing API > >> > >> This API is experemental. It may be changed or removed. > >> It should be used only for really often used functions. > >> (Keep the original parsing code and wrap usage with #ifndef FAST_ZPP) > >> > >> Changed paths: > >> M Zend/zend.h > >> M Zend/zend_API.c > >> M Zend/zend_API.h > >> M Zend/zend_builtin_functions.c > >> M Zend/zend_operators.c > >> M Zend/zend_operators.h > >> M ext/pcre/php_pcre.c > >> M ext/reflection/php_reflection.c > >> M ext/spl/spl_array.c > >> M ext/standard/array.c > >> M ext/standard/basic_functions.c > >> M ext/standard/file.c > >> M ext/standard/filestat.c > >> M ext/standard/html.c > >> M ext/standard/math.c > >> M ext/standard/string.c > >> M ext/standard/type.c > >> M ext/standard/url.c > >> > >> > >> -- > >> PHP CVS Mailing List (http://www.php.net/) > >> To unsubscribe, visit: http://www.php.net/unsub.php > > > > > > > > -- > > Pierre > > > > @pierrejoye | http://www.libgd.org >
