BTW: why not to wrap big integers into special IS_OBJECT? It would keep everything working out of the box (without BIGINT), and would allow to eliminate more than half of unnecessary changes.
In the past we made similar decision for closures. Thanks. Dmitry. On Thu, Jan 15, 2015 at 2:01 PM, Andrea Faulds <a...@ajf.me> wrote: > Hey Dmitry, > > On 15 Jan 2015, at 07:56, Dmitry Stogov <dmi...@zend.com> wrote: > > ext/session and ext/json are required by most apps. > Actually I stopped attempts to build it when I saw compilation errors in > ext/session. > > Thanks. Dmitry. > > > Oh dear, does ext/session not build? :/ > > So far I've only built the branch with --disable-all. > > In the case of most extensions, the main source of compilation errors will > be changes to certain Zend Engine functions. In particular, > is_numeric_string_ex needs to support bigints now and has an extra > parameter. I don't think I changed very many other functions. > > Porting extensions should for the most part be relatively simple. Most > extensions are just sets of functions and use zpp. If they're using the 'l' > specifier (Z_PARAM_LONG) they'll continue to work. In most cases there is > no need to update an 'l' parameter to support bigints. The length of a > string can't exceed PHP's max integer size, for example. Of course, there > are some functions where it would have a clear benefit to add bigint > support. > > The main problem with extensions is 'z' > > > > On Thu, Jan 15, 2015 at 10:44 AM, Pierre Joye <pierre....@gmail.com> > wrote: > >> On Thu, Jan 15, 2015 at 8:05 AM, Dmitry Stogov <dmi...@zend.com> wrote: >> > Oh, it's still in draft state. >> > Too may extensions are missing ext/seesion, ext/json, ext/pdo. >> > Only very simple tests may be done now, and they can't predict impact on >> > real-life applications. >> >> We may as well try to help here. >> >> This patch is anything we want but simple. I really do not want to see >> Andrea going down the pain we had with the 64bit patch. So let >> organize ourselves to avoid that. >> >> Step 1: >> >> Which extensions do we consider as critical to actually get a clue >> about the impact? >> >> I see session, standard ( ;) ), json on top of my head. Which other? >> >> Let help Andrea to port these exts and do the other once we know if >> the RFC is accepted or not. >> >> Cheers, >> Pierre >> > >
