On 06/22/2015 03:00 PM, Dmitry Stogov wrote: > > > On Mon, Jun 22, 2015 at 8:35 PM, Rasmus Lerdorf <ras...@lerdorf.com > <mailto:ras...@lerdorf.com>> wrote: > > On 06/22/2015 01:27 PM, Dmitry Stogov wrote: > > Actually, when you added type hints, php compiler stopped optimizing and > > using ZEND_DEFINED (and others) instead of internal function calls, but > > of course this shouldn't change behavior. I'll need to take a look into > > difference. > > Right, behaviour shouldn't change, but couldn't we also make it so that > arginfo for internal calls is only used by reflection? We can do all the > type checking we need right in ZPP as we do now. Let's just ignore > arginfo entirely for these calls. > > > In general, we can, if we remove corresponding code in zend_vm_def.h, > and also some checks for ZEND_HAS_TYPE_INFO and internal functions in > zend_compile.c.
I think that is the way to go. We didn't have any type info there before so we are not losing any functionality, and obviously adding it produces weird side effects and slows things down. Plus we should get a very small performance increase by removing the type info check entirely. -Rasmus
signature.asc
Description: OpenPGP digital signature
