Hi Hannes,

On Fri, Jun 26, 2015 at 12:51 PM, Yasuo Ohgaki <yohg...@ohgaki.net> wrote:

> On Fri, Jun 26, 2015 at 10:48 AM, Hannes Magnusson <
> hannes.magnus...@gmail.com> wrote:
>
>> Why do you think its undocumented?
>> http://php.net/manual/en/sessionhandler.create-sid.php
>>
>
> Rename discussion was there. And I explicitly discussed "it's undocumented
> and it violates CODING_STANDARDS", but it was added recently (after the
> discussion I suppose).
>
> [yohgaki@dev session]$ svn log -r 334814
> ------------------------------------------------------------------------
> r334814 | aharvey | 2014-09-09 04:49:26 +0900 (2014年09月09日 (火)) | 2 lines
>
> Add documentation for SessionHandler::create_sid().
>
> ------------------------------------------------------------------------
>
> 334814    aharvey     <classname>SessionHandler</classname> is a special
> class that can be used
> 334814    aharvey     to expose the current internal PHP session save
> handler by inheritance.
> 334814    aharvey     There are seven methods which wrap the seven
> internal session save handler
> 334814    aharvey     callbacks (<parameter>open</parameter>,
> <parameter>close</parameter>,
> 334814    aharvey     <parameter>read</parameter>,
> <parameter>write</parameter>,
> 334814    aharvey     <parameter>destroy</parameter>,
> <parameter>gc</parameter> and
> 334814    aharvey     <parameter>create_sid</parameter>).  By default,
> this class will wrap
> 334814    aharvey     whatever internal save handler is set as defined by
> the
> 334814    aharvey     <link
> linkend="ini.session.save-handler">session.save_handler</link>
> 334814    aharvey     configuration directive which is usually
> <parameter>files</parameter> by
> 334814    aharvey     default.  Other internal session save handlers are
> provided by PHP
> 334814    aharvey     extensions such as SQLite (as
> <parameter>sqlite</parameter>), Memcache (as
> 334814    aharvey     <parameter>memcache</parameter>), and Memcached (as
> 334814    aharvey     <parameter>memcached</parameter>).
>
> I think this should be reverted.
>

Or it may stay there.
It's just a matter of having a copy of create_sid().
I'll add documentation.

Regards,

--
Yasuo Ohgaki
yohg...@ohgaki.net

Reply via email to