did you see my patch? It already uses run_time_cache of calling op_array to get getter property offset.
It's also possible to "allocate" slots in "run_time_cache" of caller op_array at compile_time, increasing op_array->cache_size. (see zend_compile.c), but I don't see a big reason to do it. Thanks. Dmitry. ________________________________ From: Lin Yo-An <cornelius.h...@gmail.com> Sent: Tuesday, April 5, 2016 17:32 To: Dmitry Stogov Cc: Xinchen Hui; Nikita Popov; Bob Weinand; Joe Watkins; internals Subject: Re: Object getter method optimization On Tue, Apr 5, 2016 at 10:14 PM, Dmitry Stogov <dmi...@zend.com<mailto:dmi...@zend.com>> wrote: I think, op_array->type and op_array->fn_flags can't be reused. Also, usage of op_array->run_time_cache is safer (I remember, I saw some SIGSEGV with your patch and opcache.protect_memory=1) Got it. Does run_time_cache vary when caller is different? maybe I can use the first 2 bytes for the accessor information. Cheers, Yo-An
