Hi Joe,
I've add implementation for nullable typed properties (as they fit into the
patch design), but RFC missed any description of nullable properties.
See tests Zend/tests/type_declarations/typed_properties_047.phpt,
Zend/tests/type_declarations/typed_properties_048.phpt,
Zend/tests/type_declarations/typed_properties_049.phpt
I'm not sure, if this is what the voters expect. At least I don't like the
facts that "?int $foo;" declares uninitialized property; "?int $foo = NULL" may
be unset() and became uninitialized; and it's an open question if "int $foo =
NULL;" should be supported as nullable. Inheritance rules for typed nullable
properties are also missed.
Personally, I think the RFC was moved into voting state too early (without good
enough implementation, and with missing topics).
The current implementation is better (performance penalty reduced to ~2%), but
still have unsolved problems.
May be it's better to cancel voting, solve problems, finish the implementation
and add missing questions into RFC...
I'm going to help with implementation in any case, but we should agree on what
we are doing.
Thanks. Dmitry.
________________________________________
From: Joe Watkins <pthre...@pthreads.org>
Sent: Friday, May 20, 2016 9:05:34 AM
To: PHP internals; Phil Sturgeon
Subject: [PHP-DEV] [RFC][Vote] Typed Properties
Morning internals,
Since we have our answer on nullable types, typed properties can now go
to vote.
https://wiki.php.net/rfc/typed-properties#vote
Note that, support for nullability as RFC'd will be merged when the
implementation for nullable_types is merged into master.
Please participate.
Cheers
Joe
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
