On Fri, Jan 5, 2018 at 3:50 AM, Jan Ehrhardt <php...@ehrhardt.nl> wrote: >>Is it on purpose that the release-zip on github contains PHP 7.2.1-dev? >>See the main/php_version.h in the zip at >>https://github.com/php/php-src/releases > No, that was an accident. Most of my process is automated, but that got derailed slightly with the need to fill in for 7.1 and I goofed up. Also this was my first non-alpha/beta/RC release, so I got semi-whelmed by that too. (Not overwhelmed, just whelmed). Sorry. :( Unfortunately, it's too late to move the tag to the right commit (which does exist!). FWIW, the official (non-github) tarballs are correct.
> The main reason why I prefer the github zips over the zips at > http://windows.php.net/download/ is some kind of mismatch in the UTF-8 > filenames: > Whaaaa? That's broken and we should try to fix it. I'll say that the latest php-7.2.1 tarballs unpack fine for me. (e.g. ext/bz2/tests/003私はガラスを食べられます.txt.bz2) maybe you're missing a locale? > The "central" filename version is the correct one, like the filename at > https://github.com/php/php-src/tree/master/ext/bz2/tests > Okay, so you end up with the correct file on your filesystem, it's just a warning during untarring? > The zips at github do not have the mismatch and do contain the correct > filenames. So github seems to handle UTF-8 filenames in better way than > https://github.com/php/php-src/commit/3d3f11ede4cc7c83d64cc5edaae7c29ce9c6986f > Right. So it's likely the tar producer doing something weird. php-src/makedist is doing a sort of git-archive, untar, add files, retar dance (to ensure a clean state), whereas I assume github is just doing a straight git-archive. For the sake of reproducibility, what's your `tar --version`? My build container is using GNU tar 1.27.1, and git 2.1.4 -Sara -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
