Hi Nikita, thanks for the heads-up. I committed a potential fix (untested) hope it works once deployed in an hour or so.
Zachary, you might review my fix http://git.php.net/?p=web/bugs.git;a=c ommit;h=5d86832595a5e694859f45aaaf554cf24a24af39 johannes On Do, 2018-08-09 at 15:26 +0200, Nikita Popov wrote: > On Thu, Aug 9, 2018 at 1:54 AM, Hoffman, Zachary Robert <zrhoffman@ku > .edu> > wrote: > > > > > > > > > On Wed, 2018-08-08 at 18:16 +0200, Johannes Schlüter wrote: > > > > > > > > > On August 8, 2018 6:06:00 PM GMT+02:00, "Johannes Schlüter" < > > > johan...@schlueters.de> wrote: > > > > > > > > > > > > > > > > On August 8, 2018 5:59:51 PM GMT+02:00, "Hoffman, Zachary > > > > Robert" > > > > <zrhoff...@ku.edu> wrote: > > > > > > > > > > On Wed, 2018-08-08 at 16:14 +0200, Johannes Schlüter wrote: > > > > > > > > > > > > On Di, 2018-08-07 at 15:10 -0500, Sara Golemon wrote: > > > > > > On Tue, Aug 7, 2018 at 1:17 PM, Tymoteusz Motylewski > > > > > > <t.motylew...@gmail.com> wrote: > > > > > > > > > > > > - the UI is terrible (not useful, confusing, misleading) > > > > > > > > > > > > UI is harsh and a bit 90s in styling, but I have a hard > > > > > > time > > > > agreeing > > > > > > > > > > > > > > > > > with the rest of that statement. What is confusing to you? > > > > > > > > > > > > My biggest issue with the UI is the selection of category > > > > > > when > > > > > > reporting/editing bugs. That lst is huuuuge. Other than > > > > > > that > > > > > > I'm > > > > > happy > > > > > > > > > > > > it's no JavaScript overloaded thing, but simply works. > > > > > > (room for improvement exits) > > > > > While we are talking about the "package affected" dropdown, > > > > > one > > > > > accessibility issue is that the package names are indented by > > > > category, > > > > > > > > > > which makes it impossible to autocomplete a package name > > > > > using > > > > > your > > > > > keyboard. > > > > > > > > > > The correct way to do this is to surround each category in an > > > > > <optgroup> tag, which distinguishes category names from > > > > > package > > > > > names. > > > > That sounds good. Could you create a patch? - The list is > > > > generated > > > > here: > > > > > > https://github.com/php/web-bugs/blob/master/include/functions.php#L > > 726 > > > > > > > > > > > > When sending the mail I hoped this to be a more or less trivial > > > change, I now noticed that it's not completely trivial as the > > > list > > > data is prepared in > > > > > https://github.com/php/web-bugs/blob/master/include/functions.php#L > > 203 > > > > > > > > > The hackish way is to check for when creating the HTML ... > > > or > > > look for a better structure for the list of "pseudo packages" and > > > refactor all consumers of that global variable ... :/ > > > > > > Still it would be great and really appreciated if you are willing > > > to > > > look into it! > > Okay, I think this is done. > > > > https://github.com/php/web-bugs/pull/43 > > > > Modifying other parts of the project ended up not being necessary. > > > > -- > > Zach Hoffman > > > I'm getting some spurious changes on the category now, see the > history in > https://bugs.php.net/bug.php?id=76725&edit=1 for an example. The > current > category is no longer correctly selected in the dialog, so it > switches to > something else on every edit. > > Nikita -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
