Hi! > On Wed, May 01, 2019 at 01:13 AM Bishop Bettini <bis...@php.net> wrote: > > On Tue, Apr 30, 2019, 19:14 Theodore Brown <theodor...@outlook.com wrote: > > > > On Tue, Apr 30, 2019 at 3:59 PM Bishop Bettini <bis...@php.net> wrote: > > > > > Excellent. I hope we can make the case this time. Please > > > request Wiki karma [1], and we'll iterate on it there. > > > > I was granted karma, and published an initial RFC draft: > > https://wiki.php.net/rfc/numeric_literal_separator. > > > > I would greatly appreciate help with the implementation, since I > > don't have much experience with C and haven't contributed to PHP before. > > > > Also let me know if you have any ideas for improving the RFC. > > > > I am happy to help with these. Let us take the RFC refinement and > implementation details conversation off-list. Then come back when prepared > to present for discussion.
I would think that pretty much the whole of the original implementation[1] should be reusable (maybe some merge conflicts to fix only). But anyway, I can offer some support with the implementation, if needed. Thanks, Tom [1]: https://github.com/php/php-src/pull/1699
