On Fri, Sep 28, 2012 at 10:20:18AM -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Sep 28, 2012 at 02:23:57PM +0200, Joerg Roedel wrote:
> > +static void iommu_flush_irt_all(struct amd_iommu *iommu)
> > +{
> > + u32 devid;
> > +
> > + for (devid = 0; devid <= 0xffff; ++devid)
>
> Should this be #define? Or perhaps based of sizeof?
I'll add a define for that. The 0xffff is a hardware constant, so sizeof
will not work.
> Is there a specific reason that it is u16 in the build_inv_irt but
> here it is u32?
Yes, with u16 the loop-counter will overflow and make it to an endless
loop.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
