I'm looking over the bug reports, and I'm trying to understand why you need two mechanisms. You have one table (pci_dev_dma_source_map) that maps one devfn to a secondary one, and a second table (pci_dev_dma_multi_source_map) that gives a 2-bit bitmap of function numbers.
But as I understand it, all the Marvell devices listed there always have a devfn of 00.0, so you could just move them to the first table with a mapping to 00.1. If they also have device/function 00.1 using a requester ID of 00.0 you could add a second entry. The only time you'd need a bitmap would be if the device ended up on function 2 or higher and still used functions 0 and 1 in request IDs. Now, unfortunately this does not cover the phantom functions case, but that could be done with separate code. The other question is when to do the lookup. I don't know how often IOMMU mapping is done, and if linear search through a list of PCI devices would be a performance problem. It would be nicer to have a standard PCI fixup done once which sets a flag in the pci_dev to either note the actual secondary devfn, or set a flag to trigger the secondary lookup only on the devices that need it. There's certainly room in the pci_dev for a second 8-bit devfn field, Let me work up a patch based on that... _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
