On Fri, Sep 12, 2014 at 05:34:54PM +0100, Will Deacon wrote: > We need to ensure that the IOMMUs in the system have a chance to perform > some basic initialisation before we start adding masters to them. > > This patch adds a call to of_iommu_init before of_platform_populate.
Why can't you call it from of_platform_populate() directly? That way it would be usable for all architectures rather than just ARM. Eventually we're going to need the same thing for 64-bit ARM (and possibly others as well). I also don't like how this uses what is essentially initcall ordering when solutions have been proposed in the past to properly integrate this with deferred probe and allow IOMMU drivers to be proper drivers. We keep adding these special cases for devices that need to be probed early and I think it's turning into a mess. Thierry
pgpU6kfafIocg.pgp
Description: PGP signature
_______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
