On Mon, Sep 22, 2014 at 01:08:27PM +0200, Arnd Bergmann wrote: > On Monday 22 September 2014 11:36:15 Thierry Reding wrote: > > On Fri, Sep 12, 2014 at 05:34:54PM +0100, Will Deacon wrote: > > > We need to ensure that the IOMMUs in the system have a chance to perform > > > some basic initialisation before we start adding masters to them. > > > > > > This patch adds a call to of_iommu_init before of_platform_populate. > > > > Why can't you call it from of_platform_populate() directly? That way it > > would be usable for all architectures rather than just ARM. Eventually > > we're going to need the same thing for 64-bit ARM (and possibly others > > as well). > > IIRC, of_platform_populate can be called multiple times, even recursively > be drivers that populate their own child devices.
Indeed. Perhaps it could be conditionally called when root == NULL. But perhaps that's not safe either. Anyway, I still think we shouldn't be making this some randomly placed early initcall anyway. Thierry
pgpbVmSgh0xBx.pgp
Description: PGP signature
_______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
