> -----Original Message----- > From: Emil Medve [mailto:[email protected]] > Sent: Wednesday, January 28, 2015 8:05 PM > To: [email protected]; [email protected]; [email protected]; > Sethi Varun-B16395 > Cc: Medve Emilian-EMMEDVE1 > Subject: [PATCH 03/26] iommu/fsl: Remove unused/extra includes > > linux/modules.h - drivers can't be a module > linux/bootmem.h - no boot time memory allocator is used > linux/notifier.h - not used > etc. > > Factorize common includes into fsl_pamu.h > > Signed-off-by: Emil Medve <[email protected]> > --- > drivers/iommu/fsl_pamu.c | 16 +++------------- > drivers/iommu/fsl_pamu.h | 2 ++ > drivers/iommu/fsl_pamu_domain.c | 20 ++------------------ > 3 files changed, 7 insertions(+), 31 deletions(-) > > diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c index > 7d9f8a0..d3a9fff 100644 > --- a/drivers/iommu/fsl_pamu.c > +++ b/drivers/iommu/fsl_pamu.c > @@ -18,24 +18,14 @@ > > #define pr_fmt(fmt) "fsl-pamu: %s: " fmt, __func__ > > -#include <linux/init.h> > -#include <linux/iommu.h> > -#include <linux/slab.h> > -#include <linux/module.h> > -#include <linux/types.h> > -#include <linux/mm.h> > +#include "fsl_pamu.h" > + > #include <linux/interrupt.h> > -#include <linux/device.h> > -#include <linux/of_platform.h> > -#include <linux/bootmem.h> > #include <linux/genalloc.h> > -#include <asm/io.h> > -#include <asm/bitops.h> > + > #include <asm/mpc85xx.h> > #include <asm/fsl_guts.h> > > -#include "fsl_pamu.h" > - > /* define indexes for each operation mapping scenario */ > #define OMI_QMAN 0x00 > #define OMI_FMAN 0x01 > diff --git a/drivers/iommu/fsl_pamu.h b/drivers/iommu/fsl_pamu.h index > 8fc1a12..a7794b5 100644 > --- a/drivers/iommu/fsl_pamu.h > +++ b/drivers/iommu/fsl_pamu.h > @@ -19,6 +19,8 @@ > #ifndef __FSL_PAMU_H > #define __FSL_PAMU_H > > +#include <linux/iommu.h> > + > #include <asm/fsl_pamu_stash.h> > > /* Bit Field macros > diff --git a/drivers/iommu/fsl_pamu_domain.c > b/drivers/iommu/fsl_pamu_domain.c index 48a72b3..7ea93ae 100644 > --- a/drivers/iommu/fsl_pamu_domain.c > +++ b/drivers/iommu/fsl_pamu_domain.c > @@ -19,26 +19,10 @@ > > #define pr_fmt(fmt) "fsl-pamu-domain: %s: " fmt, __func__ > > -#include <linux/init.h> > -#include <linux/iommu.h> > -#include <linux/notifier.h> > -#include <linux/slab.h> > -#include <linux/module.h> > -#include <linux/types.h> > -#include <linux/mm.h> > -#include <linux/interrupt.h> > -#include <linux/device.h> > -#include <linux/of_platform.h> > -#include <linux/bootmem.h> > -#include <linux/err.h> > -#include <asm/io.h> > -#include <asm/bitops.h> > - > -#include <asm/pci-bridge.h> > -#include <sysdev/fsl_pci.h> > - > #include "fsl_pamu_domain.h" > > +#include <sysdev/fsl_pci.h> > + > /* > * Global spinlock that needs to be held while > * configuring PAMU. > -- > 2.2.2 Acked-by: Varun Sethi <[email protected]>
_______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
