Hi Emil, > -----Original Message----- > From: Emil Medve [mailto:[email protected]] > Sent: Wednesday, January 28, 2015 8:05 PM > To: [email protected]; [email protected]; [email protected]; > Sethi Varun-B16395 > Cc: Medve Emilian-EMMEDVE1 > Subject: [PATCH 11/26] iommu/fsl: Fix checkpatch type OOM_MESSAGE > > WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message > + if (!data) { > + dev_err(&pdev->dev, "PAMU isr data memory allocation > + failed\n"); > > Signed-off-by: Emil Medve <[email protected]> > --- > drivers/iommu/fsl_pamu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c index > 4f1926b..6f9c976 100644 > --- a/drivers/iommu/fsl_pamu.c > +++ b/drivers/iommu/fsl_pamu.c > @@ -1041,7 +1041,6 @@ static int __init fsl_pamu_probe(struct > platform_device *pdev) > > data = kzalloc(sizeof(*data), GFP_KERNEL); > if (!data) { > - dev_err(&pdev->dev, "PAMU isr data memory allocation > failed\n"); > ret = -ENOMEM; > goto error; > } I think this is fine, there are other places as well where we have error prints while setting the ENOMEM as the return code.
-Varun _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
