On Fri, 16 Oct 2015 16:33:42 +0100 Robin Murphy <[email protected]> wrote:

> __GFP_WAIT is going away to live its life under a new identity; convert
> __iommu_alloc_attrs() to the new helper function instead.
> 
> ...
>
> --- a/arch/arm64/mm/dma-mapping.c
> +++ b/arch/arm64/mm/dma-mapping.c
> @@ -566,7 +566,7 @@ static void *__iommu_alloc_attrs(struct device *dev, 
> size_t size,
>        */
>       gfp |= __GFP_ZERO;
>  
> -     if (gfp & __GFP_WAIT) {
> +     if (gfpflags_allow_blocking(gfp)) {
>               struct page **pages;
>               pgprot_t prot = __get_dma_pgprot(attrs, PAGE_KERNEL, coherent);

Seems unnecessarily elaborate.  What's wrong with

--- 
a/arch/arm64/mm/dma-mapping.c~mm-page_alloc-rename-__gfp_wait-to-__gfp_reclaim-arm-fix
+++ a/arch/arm64/mm/dma-mapping.c
@@ -562,7 +562,7 @@ static void *__iommu_alloc_attrs(struct
         */
        gfp |= __GFP_ZERO;
 
-       if (gfp & __GFP_WAIT) {
+       if (gfp & __GFP_RECLAIM) {
                struct page **pages;
                pgprot_t prot = __get_dma_pgprot(attrs, PAGE_KERNEL, coherent);
 

?
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to