On Wed, 2017-11-22 at 11:25 -0800, Sohil Mehta wrote:
> From: Gayatri Kammela <gayatri.kamm...@intel.com>
> +static int intel_iommu_regs_open(struct inode *inode, struct file
> *file)
> +{
> + return single_open(file, intel_iommu_debugfs_regs_show,
> + inode->i_private);
> +}
> +
> +static const struct file_operations intel_iommu_regs_fops = {
> + .open = intel_iommu_regs_open,
> + .read = seq_read,
> + .llseek = seq_lseek,
> + .release = single_release,
> +};
Please, be consistent with file name and functions, i.e.
intel_iommu_debugfs_regs_show -> intel_iommu_regset_show
and so on.
Moreover, see the patch I have just sent [1] and use same
DEFINE_SHOW_ATTRIBUTE() macro here. In that case we would easily move it
to seq_file.h for everyone to use in the future.
> + if (!debugfs_create_file("intel_iommu_regset", S_IRUGO,
> + iommu_debug_root, NULL,
> &intel_iommu_regs_fops
[1]: https://marc.info/?l=linux-bluetooth&m=151138535801354&w=2
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
