>> + if (smmu->impl->global_fault) >> + return smmu->impl->global_fault(irq, smmu);
>Can't we just register impl->global_fault (if set) instead of >arm_smmu_global_fault as the handler when we first set up the IRQs in >arm_smmu_device_probe()? >Ideally we'd do the same for the context banks as well, although we might need >an additional hook from which to request the secondary IRQs that the main flow >can't accommodate. When first implemented theis patch, I think there were compile issues in accessing struct arm_smmu_domain from arm-smmu-nvidia.c as it was part of arm-smmu.c. To avoid issues accessing arm_smmu_domain. It did this for context fault and did same for global fault for uniformity. Now, I see that it is part of arm-smmu.h. Let me update code to register implementation hooks directly. Thanks -KR _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
