>> +static irqreturn_t nsmmu_context_fault_inst(int irq, >> + struct arm_smmu_device *smmu, >> + int idx, int inst);
>More of these signed integers that could be unsigned. Also why the need to >predeclare this? Can you not just put the definition of the function up here? The singed integers are based on original function prototype from arm-smmu.c. inst can be updated to unsigned. This is because I was checking context faults from global fault handler as well. This can avoided by using interrupt lines of all the instances across global and context irq entries. Let me update. > + if (smmu->impl->global_fault) > + return smmu->impl->global_fault(irq, smmu); >>... and here about the extra level of indirection. Fixing in next version. -KR
